[WIP] Fix performance regression due to flattening Wires objects #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzaia18
added
WIP 🚧
|
Hello. You may have forgotten to update the changelog!
|
…ormant than isinstance() for this use case
|
Scrapping this PR for now. May revisit later. |
jzaia18
added
the
do not merge ⚠️
JerryChen97
reviewed
Mar 21, 2025
| @@ -71,6 +71,8 @@ def _process(wires): | |||
| # Note, this is not the same as `isinstance(wires, Iterable)` which would | |||
| # pass for 0-dim numpy arrays that cannot be iterated over. | |||
| tuple_of_wires = tuple(wires) | |||
| if type(wires) is range: # pylint: disable=unidiomatic-typecheck | |||
There was a problem hiding this comment.
Suggested change
| if type(wires) is range: # pylint: disable=unidiomatic-typecheck | |
| if isinstance(wires, range): |
Try this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
#6933 fixes a bug where Wires objects could be nested causing a 2-dimensional structure. However, for workloads that create large number of Wires objects, the extra work to flatten an already 1-dimensional iterable causes a performance regression (in some cases as much as 0.8x).
Description of the Change:
Cache tuples so workloads that commonly use the same sets of wires the flattening step can be skip redundant flattening operations. Prevent running the flattening logic when the input wires is of type
rangesince these inputs will always be flat.Benefits:
Increases performance back to be within +/- 0.02x of before the wire-flattening change for tested workloads.
Possible Drawbacks:
Increased code complexity
Related GitHub Issues:
[sc-86632] [sc-87017]
Changes co-authored with @mlxd