Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test that checked that multi-controlled global-phase decomposition raises a warning #1522

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

joeycarter
Copy link
Contributor

Context: A decomposition for multi-controlled global phases was recently added in PennyLane: PennyLaneAI/pennylane#6936. Catalyst contained a test test_global_phase_decomp_raises_warning that checked that such decompositions raise a warning. This test is therefore no longer needed and can be removed.

Description of the Change: Removes the test test_global_phase_decomp_raises_warning.

Benefits: This test is currently failing with PennyLane latest. Removing it will fix the pytest failure.

@joeycarter joeycarter requested a review from maliasadi February 14, 2025 15:50
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (6942e30) to head (62c99c7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1522      +/-   ##
==========================================
+ Coverage   90.90%   95.90%   +5.00%     
==========================================
  Files          21       80      +59     
  Lines        1485     8336    +6851     
  Branches        0      779     +779     
==========================================
+ Hits         1350     7995    +6645     
- Misses        135      286     +151     
- Partials        0       55      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeycarter joeycarter merged commit 2636b05 into main Feb 14, 2025
41 checks passed
@joeycarter joeycarter deleted the joeycarter/remove-stale-global-phase-decomp-test branch February 14, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants