skip inlining #1520
Draft
skip inlining #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I remember this as well, we should do a bit of digging to confirm why it was needed and that it no longer is 🤔 (before merging this PR, in the meantime it's fine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Inlining creates large functions. Some passes have a complexity that grows faster than O(n) in the order of operations on functions. So large functions means larger compilation time.
Description of the Change: This PR disables inlining.
Benefits: Reduce compilation time
Possible Drawbacks: Increased runtime
Related GitHub Issues: At the moment this PR is just for benchmarking.