-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture "for_loop" workflow #1509
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
=======================================
Coverage 96.73% 96.74%
=======================================
Files 76 76
Lines 8219 8236 +17
Branches 779 779
=======================================
+ Hits 7951 7968 +17
Misses 213 213
Partials 55 55 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rauletorresc!
I am not very familiar with the Catalyst pipeline, but this LGTM and I see that we are inheriting from the same PlxprInterpreter
. I am very curious to test this with the features we are currently working on 🚀
Context: Currently, Catalyst cannot compile and execute captured workflows with
for_loop
control flow. E.g.:Description of the Change: Reuse the Branch interpreter created at #1468
Benefits: Extended support for plxpr capture.
[sc-81880]