-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile error for Mbed TF-M V8M target #81
base: master
Are you sure you want to change the base?
Conversation
Use DEVICE_FLASH to exclude KVStore/FLASHIAP code
Have a look? |
Thank you, I'll take a look. |
@ccli8 |
@marcuschangarm Oh, it is runtime error, not compile error. As you pointed out, mbed-cloud-client-example/source/platform/mbed-os/mcc_common_setup.cpp Lines 415 to 419 in 3d8d83b
|
@ccli8
We support KV store on other mediums than internal flash, so using DEVICE_FLASH is too restrictive. |
@marcuschangarm The above patch can work for me. |
@marcuschangarm Need I update this PR to include above modification, or you'll merge it separately? |
@ccli8 Sorry, I can see my message was ambiguous. I've made the changes to our internal repository and it should be part of one of the next releases. I'll close this PR once everything is ready to go. |
[x] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[x] I confirm the moderators may change the PR before merging it in.
[x] I understand the release model prohibits detailed Git history and my contribution will be recorded to the list at the bottom of CONTRIBUTING.md.
Summary of changes
Use
DEVICE_FLASH
to excludeKVStore
/FLASHIAP
code for Mbed TF-M V8M target, usually withoutFLASHIAP
.