Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gelonian, Qin, Neo Minoan and Cretan cultures #2440

Merged
merged 12 commits into from
Jan 22, 2025
Merged

Add Gelonian, Qin, Neo Minoan and Cretan cultures #2440

merged 12 commits into from
Jan 22, 2025

Conversation

Voldarius
Copy link
Contributor

This has all four cultures. Gelonian, Qin, Neo Minoan, and Cretan.

@Voldarius
Update converter_cultures.txt
d0b8ad1 
This has all four cultures. Gelonian, Qin, Neo Minoan, and Cretan.
@IhateTrains IhateTrains changed the title Update converter_cultures.txt Add Gelonian, Qin, Neo Minoan and Cretan cultures Jan 18, 2025
@IhateTrains IhateTrains added the enhancement New feature or request label Jan 18, 2025
@IhateTrains IhateTrains linked an issue Jan 18, 2025 that may be closed by this pull request
Possible new cultures to be added #2380
Closed
3 tasks
@IhateTrains
Copy link
Member

IhateTrains commented Jan 18, 2025 •
edited
Loading

Stuff left to be added by me:

  • localizations
  • culture mappings
  • neo_minoan should only appear in provinces where the holder is of cretan culture in Imperator and is of k or e rank (can be implemented through new culture mapping parameters or just as a game start on-action script)

@IhateTrains IhateTrains mentioned this pull request Jan 18, 2025
Closed
3 tasks
@Voldarius
Copy link
Contributor Author

File is updated with all necessary changes.

@IhateTrains IhateTrains merged commit 4910cf4 into ParadoxGameConverters:master Jan 22, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IhateTrains IhateTrains IhateTrains approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible new cultures to be added
2 participants
@Voldarius @IhateTrains