Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show error message when failing to integrate with Azure DevOps #10888

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

Dschoordsch
Copy link
Contributor

Description

Handling for showing the error message was missing.

Demo

image

Testing scenarios

Add an early return to

const addTeamMemberIntegrationAuth: MutationResolvers['addTeamMemberIntegrationAuth'] = async (

  return standardError(new Error('GEORG was here'), {userId: viewerId})

and try integrating.

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

Handling for showing the error message was missing.
@github-actions github-actions bot added size/s and removed size/xs labels Feb 18, 2025
@Dschoordsch Dschoordsch merged commit f2d530d into master Feb 18, 2025
6 checks passed
@Dschoordsch Dschoordsch deleted the fix/azureDevOpsErrorMessage branch February 18, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant