Implement Patch Roulette and Git history reconstruction for Minecraft updates #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on when updating Minecraft
Patches might target files that no longer exist in newer versions. In such a case, no target file will exist in the mojang source directory.
This might be completely wrong. Awaiting jmp.
lynxplay
force-pushed
the
updating-history
branch
from
a9b1f1b to
b5b6db7
Compare
We cannot just remove rejectsDir here as the git patches need to be moved to the reject dir.
|
Pushed some maybe faulty changes needed during update testing 1.21.5-pre1. |
lynxplay
force-pushed
the
updating-history
branch
2 times, most recently
from
ae93a00 to
2fe201f
Compare
In case multiple patches are applied, it is important to apply as many patches as possible to allow manual resolution of failed applies (e.g. missing patch file, source file missing, etc). The alternative is a complete re-apply of all selected patches, which is unwanted.
lynxplay
approved these changes
Mar 13, 2025
jpenilla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.