Add PlayerLoadedWorldEvent

[FlorianMichael]

Starting with Minecraft 1.21.4, the client sends a newly player_loaded packet as soon as the client closes the downloading terrain screen / starts rendering the world. This PR adds a new event so plugins can execute/delay code until a player is considered as loaded, which happens if they send the packet or if they haven't sent the packet for 60 ticks.

Same as PaperMC/Velocity#1466

I would appreciate any feedback on the API.

[lynxplay]

Generally a bit unsure on both the naming of the event and the exposed caused.
PlayerLoadedEvent can mean a lot, the packet name is fine-ish given it is a packet.
But in the context of the API, it could easily be confused for player data being loaded. As for alternative suggestions, uh nothing immediately comes to mind?
PlayerClientLoadedEvent?

In regards to the cause, I'd rather not introduce the concept of "packet" triggered.
Tho I am having a bit of a hard time to think of a usecase for the cause, so if you can elaborate on that, maybe that'll help my understanding 👍

[FlorianMichael]

Hm yeah I can try to find a better name for the class (my personal favourite would be PlayerLoadedPacketEvent or the name you provided).

I added the Cause so that people can make a difference between the client actually setting it's local state to loaded or the server doing it, I personally don't need it.

[masmc05]

Since lynxplay mentioned bad naming, I have some suggestions

[masmc05]

I think you accidentally removed unused imports in the newest commits

[molor]

Why not PlayerReadyEvent? Because World already loaded at the time of event call, so current event name looks a little unclear IMO.

[FlorianMichael]

I don't like the term Ready honestly, renamed it to PlayerLoadedWorldEvent which should be clear enough now.

[Cryptite]

PlayerLoadedWorldEvent to me sounds too much still like WorldLoadEvent and doesn't strongly enough indicate this is a client-state/behavior event. Might I propose PlayerFinishJoinEvent or PlayerPostJoinEvent (since we have some PostXXXEvents, or something to that effect?

I just feel it's important not to name it something that sounds like Bukkit-level actions, but rather is a later phase of joining a server.

Don't mind PlayerReadyEvent as well, personally.

Use-case wise I can see a lot of visual-state things I would move into something like this, setting team packets, checking for player notifications, or anything that a player wouldn't need to "see" while still loading the game. Many clients do crash/timeout/etc during the join process as well, so not having to do extra work in those cases is attractive.

[nostalfinals]

Maybe PlayerLoadedInWorldEvent?

[lynxplay]

PlayerReadyEvent - player ready for what tho xD
`PlayerFinishJoinEvent' and the other one don't work because this is also called when the player respawns.

Realistically, it is an event that is called when the client finished loading into the world.
But yea, I'll throw some names around the PR parties if we can't find a good one xD

[Malfrador]

PlayerClientLoadedWorldEvent? That would make it explicitly clear that it has nothing to do with Bukkit world loading. And the naming would align with another client-triggered event, the PlayerClientOptionsChangeEvent

[lynxplay]

I am also good with PlayerClientLoadedWorldEvent but will discuss that with machine tomorrow prior to merge so that rename can be done by us if we do feel like it. Beyond that, needs testing but LGTM.