Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to not creating snapshots in BlockState getters #11913

Closed
wants to merge 2 commits into from

Conversation

me4502
Copy link
Member

@me4502 me4502 commented Jan 5, 2025

See #11912; PR is up to get a test jar


Download the paperclip jar for this pull request: paper-11913.zip

@me4502 me4502 requested a review from a team as a code owner January 5, 2025 09:01
@codebycam codebycam added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Jan 5, 2025
@lynxplay
Copy link
Contributor

Going to close this as we cannot merge this PR as of right now.
I do 100% think the issue is worth addressing with a PR along these lines, but we'll need to first start sending out notices to developers e.g. via nags or whatever that this behaviour is expected to change in ~1-3 releases down the line before we can pull this.

As such, in the name of keeping the PR queue to a minimum, I'll send it to the graveyard to be revived once we finished all preparations :)

@lynxplay lynxplay closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request.
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants