Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 02_dqn_pong.py #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

varenyamBakshi
Copy link

As uint8 is depreciated in later versions of pytorch, so instead use torch.bool for indexing the next_state_values. Using uint8 generates a user warning. Also actions_v tensor should be of dtype=torch.int64 to use the gather() .

As uint8 is depreciated in later versions of pytorch, so instead use torch.bool for indexing the next_state_values. Using uint8 generates a user warning. Also actions_v tensor should be of dtype=torch.int64 to use the gather() .
@varenyamBakshi
Copy link
Author

Also sir, I would like to thank you for writing such a great book. It is really helpful for me as you have beautifully combined the theoretical aspects with practical implementation. Hats off to you.

@Shmuma
Copy link
Collaborator

Shmuma commented Jul 29, 2020

Hi!

First of all, thanks a lot for the pull request and book's feedback!

I propose not to merge your change it into the master branch, but rather create separate branch to port examples to the latest pytorch. This will keep compatibility with the book, but give users the flexibility to use the recent pytorch.

@varenyamBakshi
Copy link
Author

yeah sure sir. Thanks a lot for responding. Looking forward to contribute to your book,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants