Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor changes to make input data testing easier #2713

Merged
merged 8 commits into from
Feb 5, 2024

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Feb 4, 2024

This pull request contains a few changes that will make it easier to conduct validation tests of new datasets being developed for use by Tax-Calculator. These changes have no effect on the taxes calculated by the model.

  • In the Makefile change the logic of the clean target to correspond to the existing logic in the package target.

  • In the Makefile add the --disable-warnings option to just the pytest-cps target.

  • Add a SS_all_in_agi boolean parameter to the policy_current_law.json file and use it in the SSBenefits function in the calcfunctions.py module. This parameter permits the estimation of the tax expenditure associated with the less-than-complete taxation of social security benefits.

  • Promote a local variable in the GainsTax function in the calcfunctions.py module to be a global variable defined in the records_variables.json file. This variable makes it easier to check that the existing CG_nodiff parameter is doing what it is designed to do.

  • Suppress a pandas deprecation warning in the taxcalcio.py module.

  • Break up several overly long lines in the pytest_sessionfinish function in the conftest.py module.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (552b2f8) 98.54% compared to head (fe2ff9a) 98.54%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2713   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          14       14           
  Lines        2608     2608           
=======================================
  Hits         2570     2570           
  Misses         38       38           
Flag Coverage Δ
unittests 98.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
taxcalc/taxcalcio.py 100.00% <100.00%> (ø)

@jdebacker
Copy link
Member

Thanks for this PR @martinholmer! Merging.

@jdebacker jdebacker merged commit f850d81 into PSLmodels:master Feb 5, 2024
11 checks passed
@martinholmer martinholmer deleted the datatest-changes branch February 5, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants