-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize the limitation on capital losses #2707
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2707 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 14 14
Lines 2609 2609
=======================================
Hits 2571 2571
Misses 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@MattHJensen This PR is ready for your review. Thanks! |
@jdebacker, do you think we should protect puf and cps users from setting this parameter outside of the ranges supported by their data? Or say this param isn't compatible with those data? |
@MattHJensen Good point about data limitations affecting this parameter's usefulness. To address this concern, I've added a note about this in the "notes" metadata field for the Note that I am reluctant to set Do you think this is satisfactory? |
@MattHJensen I think this PR is ready to merge. Let me know if you have further thoughts. Will merge if I don't hear back in about 24hrs. Thanks! |
This PR addresses Issue #2632 by parameterizing the capital loss limitation.