Remove deprecated warning on DebugClassLoader #22
Conversation
… it first, because Symfony\Component\Debug\DebugClassLoader is deprecated in Symfony 4.4
…ption when a definition in PHP-DI is required in Symfony DI
Switch to last version of phpunit Enable support of Symfony 5.*
Switch to last version of phpunit Enable support of Symfony 5.*
| @@ -25,7 +25,7 @@ class ContainerInteractionTest extends AbstractFunctionalTest | |||
| /** | |||
| * @test Get a Symfony entry from PHP-DI's container | |||
| */ | |||
| public function phpdi_should_get_entries_from_symfony() | |||
| public function phpdiShouldGetEntriesFromSymfony() | |||
There was a problem hiding this comment.
Could you restore the original name? (including in the other tests)
| @@ -27,6 +27,6 @@ public function testContainerAware() | |||
| /** @var ContainerAwareController $class */ | |||
| $class = $container->get(ContainerAwareController::class); | |||
|
|
|||
| $this->assertSame($container, $class->container); | |||
| $this::assertSame($container, $class->container); | |||
There was a problem hiding this comment.
These code-style changes are unrelated to the PR, could you revert them?
There was a problem hiding this comment.
Assert method are static.
| { | ||
| public function testHasFallback() | ||
| { | ||
| $wrapper = new SymfonyContainerBridge(); | ||
|
|
||
| $fallback = $this->getMockForAbstractClass(ContainerInterface::class); | ||
| $fallback->expects($this->once()) | ||
| $fallback->expects(self::once()) |
There was a problem hiding this comment.
Idem Once method are static.
|
Sorry, my mind bugged and i forgot to create branches by PR. Il will create them tomorow evening. |
|
I restored phpunit 4 and original test, I will push a new PR after the merge of this one :) |
|
I'm sorry there are too many changes in this PR, without explanations I have to assume they are unrelated. It's not possible to move forward at this time, I'll be closing this for now. |
|
I understand, no worries. Since then I have completely rework the behavior to run as bundle without having to overload the Symfony kernel. |
|
Thanks, you too! |
Hi,
This PR is about to support new DebugClass component of Symfony available in symfony/error-handler when it is available. (The legacy DebugClass is deprecated since 4.4).
Thanks