PSR-11 friendly kernels #21
Conversation
|
Hi, thanks for the PR and trying to make it work with this repository! I think those are good changes and a PSR-11 compatibility layer is great (instead of targeting PHP-DI only). But unfortunately I think this wouldn't be a good fit here:
So I encourage you to create a separate repository. In the future I could even refactor this one to use yours (or maybe get rid of this one if that's enough). By the way I have a question that I will open in the diff. |
| if ($invalidBehavior === self::EXCEPTION_ON_INVALID_REFERENCE) { | ||
| throw new ServiceNotFoundException($id, null, $e); | ||
| } | ||
| } catch (ContainerExceptionInterface $e) { | ||
| throw new \Exception('Error while retrieving the entry.', $e->getCode(), $e); |
There was a problem hiding this comment.
Why catch a more specific exception to rethrow it with a less precise one? You could just let the original exception bubble (by not catching it)?
There was a problem hiding this comment.
Because here you don't really respect Symfony's contract (which itself doesn't respect Psr/Container's contract).
Symfony's contract expects ServiceCircularReferenceException, ServiceNotFoundException and Exception to be thrown.
ContainerExceptionInterface can be thrown by $this->fallbackContainer->get($id).
But ContainerExceptionInterface does not extend or implement anything expected by Symfony.
There was a problem hiding this comment.
If I understand the problem: ContainerExceptionInterface doesn't extend/implement \Exception.
That's correct, but it's impossible to throw anything that doesn't extend exception so I think catching + rethrowing isn't necessary 🤔
There was a problem hiding this comment.
But honestly, I don't if it would work in more "structured" language. For instance, I'm not sure it would compile in Java
|
Hello, No problem, I totally understand your concerns :) |
Hello Matthieu,
I'm not sure you'll be interested by this PR, but let's try. I was looking for something able to make me use a PSR-11 container with Symfony's kernel. And I found your bridge.
But I'd like to be able to use any kind of PSR-11 container. Hence this PR where you now have "PSR 11 compatible kernel" and specific "PHP DI compatible kernel".
If you're not interested just let me know. I'll create another bridge and refer to yours for the paternity.
What's missing:
ContainerExceptionInterface(but I suck in PHPUnit, I'm too used to PhpSpec sadly...)KernelWithPsr11Container?