Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spec detection, new raids, dualspec, bugfix #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jozefmutis
Copy link

Added:

  • new raids
  • new achievements
  • detection for achievements in progress
  • more reliable spec detection for feral druids and death knights
  • dual specialization
  • table are sorted by default
  • detection from say messages

Fixed:

  • doubleclick on message doesn't send whisper message

@Ostoic Ostoic added the enhancement New feature or request label Jan 29, 2023
@Ostoic Ostoic mentioned this pull request Jan 29, 2023
@Ostoic
Copy link
Owner

Ostoic commented Jan 29, 2023

Note that I decided to change the OnDoubleClick behavior as discussed here because to me it seemed to be a more sane default. My plan is to introduce AceConfig to make this configurable for those who prefer it.

Otherwise, this looks like another great addition! I'll have to do some testing with these changes to make sure everything still works smoothly, but I plan to merge it later today or tomorrow.

Thanks again.

@MassCraxx
Copy link
Contributor

MassCraxx commented Feb 12, 2023

These are great additions! Hope they will be merged soon.

Maybe put the refresh time on 90s instead of 120s to prevent too much clutter.
And not sure if "toGc10hc" isn't too much: doesnt togc already imply its hc? So imo it should be either togc10 or toc10hc...

@MassCraxx
Copy link
Contributor

MassCraxx commented Feb 18, 2023

Because of the heavy recent changes on master, the merge conflicts got pretty big. @Ostoic If you want help with this, I went ahead and solved them here:
https://github.com/MassCraxx/RaidBrowser/tree/pr/qol-improvements

I don't want to create another PR tho, if I do @jozefmutis would not be credited for his additions.

@MassCraxx
Copy link
Contributor

MassCraxx commented Mar 11, 2023

Bump, please merge.

@xxxkowal
Copy link

bump, merge please

@xxxkowal
Copy link

xxxkowal commented Aug 27, 2023

I do it myself and when i double click on togc10-25/toc10-25, addon link the best addon "First realm gran crusader" XD I dont have that achiv, can u fix this? @jozefmutis

@DimaSheiko
Copy link

@jozefmutis Do you know if this is currently usable?

@MassCraxx
Copy link
Contributor

MassCraxx commented May 30, 2024

@jozefmutis Do you know if this is currently usable?

@DimaSheiko Alternatively try this merged and fully tested version here:
https://github.com/MassCraxx/RaidBrowser/tree/pr/qol-improvements

@DimaSheiko
Copy link

DimaSheiko commented Jun 3, 2024

@jozefmutis Do you know if this is currently usable?

@DimaSheiko Alternatively try this merged and fully tested version here: https://github.com/MassCraxx/RaidBrowser/tree/pr/qol-improvements

Nice, thank you! Are you planning to implement improvements in your fork?

@MassCraxx
Copy link
Contributor

@jozefmutis Do you know if this is currently usable?

@DimaSheiko Alternatively try this merged and fully tested version here: https://github.com/MassCraxx/RaidBrowser/tree/pr/qol-improvements

Nice, thank you! Are you planning to implement improvements in your fork?

yes, I will continue development from time to time here https://github.com/MassCraxx/RaidBrowser/tree/dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants