-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spec detection, new raids, dualspec, bugfix #27
base: master
Are you sure you want to change the base?
Conversation
Note that I decided to change the OnDoubleClick behavior as discussed here because to me it seemed to be a more sane default. My plan is to introduce AceConfig to make this configurable for those who prefer it. Otherwise, this looks like another great addition! I'll have to do some testing with these changes to make sure everything still works smoothly, but I plan to merge it later today or tomorrow. Thanks again. |
These are great additions! Hope they will be merged soon. Maybe put the refresh time on 90s instead of 120s to prevent too much clutter. |
Because of the heavy recent changes on master, the merge conflicts got pretty big. @Ostoic If you want help with this, I went ahead and solved them here: I don't want to create another PR tho, if I do @jozefmutis would not be credited for his additions. |
Bump, please merge. |
bump, merge please |
I do it myself and when i double click on togc10-25/toc10-25, addon link the best addon "First realm gran crusader" XD I dont have that achiv, can u fix this? @jozefmutis |
@jozefmutis Do you know if this is currently usable? |
@DimaSheiko Alternatively try this merged and fully tested version here: |
Nice, thank you! Are you planning to implement improvements in your fork? |
yes, I will continue development from time to time here https://github.com/MassCraxx/RaidBrowser/tree/dev |
Added:
Fixed: