Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCC-310: Fix problems related to UGX in Stripe and update SpecialCases list #526

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

OCC-310: Fix problems related to UGX in Stripe and update SpecialCases list #526

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
78021f9
Update NuGet package versions.
sarahelsaig Feb 22, 2025
4cc400d
Update vscode configs.
sarahelsaig Feb 22, 2025
fe900a0
SuppressMessage
sarahelsaig Feb 22, 2025
8487f58
Fix S6967.
sarahelsaig Feb 22, 2025
b9caf10
Fix CA1859.
sarahelsaig Feb 22, 2025
75c64d0
other fixes
sarahelsaig Feb 22, 2025
be4d710
additional permitted error lines
sarahelsaig Feb 22, 2025
057b89a
Update information based on https://docs.stripe.com/currencies#specia…
sarahelsaig Feb 23, 2025
31288d0
Add missing currency static prop for UGX.
sarahelsaig Feb 23, 2025
0035bc2
Clarification.
sarahelsaig Feb 23, 2025
b4d7665
Merge remote-tracking branch 'origin/main' into issue/OCC-310
sarahelsaig Feb 25, 2025
0ddf4fe
Update UITT version.
sarahelsaig Feb 27, 2025
47ea837
Merge remote-tracking branch 'origin/issue/OCC-310' into issue/OCC-310
sarahelsaig Feb 27, 2025
292ac18
update usings
sarahelsaig Feb 28, 2025
f9f7f15
update usings
sarahelsaig Feb 28, 2025
c243f26
Revert SecurityScanningTests.
sarahelsaig Feb 28, 2025
3c1efcc
Add cancellation token.
sarahelsaig Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Libraries/OrchardCore.Commerce.MoneyDataType/Currency.extra.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ public static ICurrency Euro
public static ICurrency TurkishLira => _defaultProvider.GetCurrency("TRY");
public static ICurrency TrinidadAndTobagoDollar => _defaultProvider.GetCurrency("TTD");
public static ICurrency NewTaiwanDollar => _defaultProvider.GetCurrency("TWD");
public static ICurrency UgandanShilling => _defaultProvider.GetCurrency("UGX");
public static ICurrency UkrainianHryvnia => _defaultProvider.GetCurrency("UAH");
public static ICurrency UsDollar => _defaultProvider.GetCurrency("USD");
public static ICurrency UruguayanPeso => _defaultProvider.GetCurrency("UYU");
Expand Down
7 changes: 5 additions & 2 deletions src/Modules/OrchardCore.Commerce.Payment/Constants/CurrencyCollectionConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@
namespace OrchardCore.Commerce.Payment.Constants;
public static class CurrencyCollectionConstants
{
public static readonly IEnumerable<string> SpecialCases = ["HUF", "TWD", "UGX"];
public static readonly IEnumerable<string> SpecialCases = ["ISK", "HUF", "TWD", "UGX"];

// Note that https://docs.stripe.com/currencies#zero-decimal contains UGX on the list as well, however this is a
// mistake because https://docs.stripe.com/currencies#special-cases explicitly states that UGX is a special case
// (see above) where it's effectively zero-decimal but uses the two-decimal format for backwards compatibility.
public static readonly IEnumerable<string> ZeroDecimalCurrencies =
[
"BIF",
Expand All @@ -16,7 +20,6 @@ public static class CurrencyCollectionConstants
"MGA",
"PYG",
"RWF",
"UGX",
"VND",
"VUV",
"XAF",
Expand Down
Loading