Handle shopping cart corruption.

OrchardCMS · Dec 29, 2023 · 29f236e · 29f236e
1 parent 42f82c4
commit 29f236e
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/Modules/OrchardCore.Commerce/Controllers/ShoppingCartController.cs b/src/Modules/OrchardCore.Commerce/Controllers/ShoppingCartController.cs
@@ -120,10 +120,22 @@ await _notifier.ErrorAsync(H["You have to accept cookies in your browser to add
     public async Task<ActionResult> Update(ShoppingCartUpdateModel cart, string shoppingCartId)
     {
         var updatedLines = new List<ShoppingCartLineUpdateModel>();
-        foreach (var line in cart.Lines)
+
+        var lines = await cart.Lines.AwaitEachAsync(async line =>
+            (Line: line, Item: await _shoppingCartSerializer.ParseCartLineAsync(line)));
+
+        if (lines.Any(line => line.Item == null))
+        {
+            await _shoppingCartPersistence.StoreAsync(new ShoppingCart(), shoppingCartId);
+
+            await _notifier.ErrorAsync(
+                H["Your shopping cart is broken and had to be replaced. We apologize for the inconvenience."]);
+            return RedirectToAction(nameof(Empty));
+        }
+
+        foreach (var (line, item) in lines)
         {
             var isValid = true;
-            var item = await _shoppingCartSerializer.ParseCartLineAsync(line);
 
             await _workflowManagers.TriggerEventAsync<CartUpdatedEvent>(
                 new { LineItem = item },