Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Handle the management of minimizing behavior #2395

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Nov 30, 2023

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Delay the minimizing behavior once the scroll is ended.

Motivation & Context

Clicking on the table of contents inside the Boosted doc leads to being stopped in the middle of the page on firefox.

Types of change

  • Refactoring (non-breaking change)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added v5 js Pull requests that update Javascript code fix labels Nov 30, 2023
@louismaximepiton louismaximepiton changed the title Docs: Handle the management of minimizing behavio Docs: Handle the management of minimizing behavior Nov 30, 2023
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit edb8920
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6596d6bcdc46e5000835c586
😎 Deploy Preview https://deploy-preview-2395--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix js Pull requests that update Javascript code v5
Projects
Status: In Progress / Draft
Development

Successfully merging this pull request may close these issues.

1 participant