Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Download app example page banner image #2268

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Sep 26, 2023

Description

Update 'Download app example' page banner image to add the new version with the '2023 Red Dot Award for Interface Design' message.

Motivation & Context

Keep the page up to date.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • (na) I have added JavaScript unit tests to cover my changes
  • (na) I have added SCSS unit tests to cover my changes

Documentation

  • (na) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (na) My change introduces changes to the migration guide
  • (na) My new component is well displayed in Storybook
  • (na) My new component is compatible with RTL
  • (na) Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@MewenLeHo MewenLeHo added the v5 label Sep 26, 2023
@MewenLeHo MewenLeHo self-assigned this Sep 26, 2023
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 68b5677
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6596cd0a1a5fdb0008ba8477
😎 Deploy Preview https://deploy-preview-2268--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MewenLeHo

This comment was marked as outdated.

@julien-deramond

This comment was marked as outdated.

@MewenLeHo

This comment was marked as outdated.

@Aniort
Copy link
Contributor

Aniort commented Sep 27, 2023

hello dear friends,
in my opinion, this logo "Reddot winner 2023" is not a a11y issue, except that it's a text image and it's a bad thing.
But, the issue, here, is that as a "normal", classic user, I don't know, the hell, what is Reddot ?!
For ergonomics reasons, we should explain a little bit more Reddot for example "Orange Design System App, winner of the 2023 Red Dot Design Award for User Interface and User Experience within the category of Brand and Communication Design" with a paragraph (p) displayed under the text to the left of the image,
nothing more to say...

@julien-deramond
Copy link
Member

/cc @CyriaqueBillard

@CyriaqueBillard
Copy link
Member

hello dear friends, in my opinion, this logo "Reddot winner 2023" is not a a11y issue, except that it's a text image and it's a bad thing. But, the issue, here, is that as a "normal", classic user, I don't know, the hell, what is Reddot ?! For ergonomics reasons, we should explain a little bit more Reddot for example "Orange Design System App, winner of the 2023 Red Dot Design Award for User Interface and User Experience within the category of Brand and Communication Design" with a paragraph (p) displayed under the text to the left of the image, nothing more to say...

Would be nice to have tough.

@MewenLeHo
Copy link
Contributor Author

MewenLeHo commented Sep 28, 2023

  • New image: ok
  • Text in image so adding description in alt attribute: ok
  • Change title on the left: ok
  • Add a paragraph on the left to give more information about Red Dot Awards (same content as the alt attribute): ok

@CyriaqueBillard and @Aniort: could you please have a look on the new version and tell me if it is ok for you or not.

To do:

  • Redo thumbnails (wait until we reech an agreement)

@CyriaqueBillard
Copy link
Member

  • New image: ok
  • Text in image so adding description in alt attribute: ok
  • Change title on the left: ok
  • Add a paragraph on the left to give more information about Red Dot Awards (same content as the alt attribute): ok

@CyriaqueBillard and @Aniort: could you please have a look on the new version and tell me if it is ok for you or not.

To do:

  • Redo thumbnails (wait until we reech an agreement)

Some changes to be applied.

  • The headline block in the banner has a fixed width of 480 px.
  • The copy block in the banner has a fix width of 480 px with right padding of 40 px, or fix width of 440 px if more convenient technically.
  • Banner to expand vertically when adding text without enlarging the width of those text blocks.
  • Updated image is attached.

IMG2

@Aniort
Copy link
Contributor

Aniort commented Oct 2, 2023

fine for me !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Need Design and/or Accessibility Review
Development

Successfully merging this pull request may close these issues.

5 participants