Door Condition per 1.6 specs, adds DoorSense support #2196
Conversation
config/august/asl-03.xml
Outdated
| <Item label="Unlocked/Open" value="2" /> | ||
| <Item label="Unlocked/Closed" value="3" /> | ||
| </Value> | ||
| </CommandClass> |
There was a problem hiding this comment.
This is not a Configuration CC id - Why is it required?
There was a problem hiding this comment.
You're right this isn't needed and I didn't understand why I was making that change. I removed the changes to this file.
cpp/src/command_classes/DoorLock.cpp
Outdated
| DoorLockCondition_Latched_Unlocked_Open = 0x06, | ||
| DoorLockCondition_Latched_Unlocked_Closed = 0x07, | ||
| }; | ||
|
|
| { | ||
| value->OnValueRefreshed(_data[3]); | ||
| value->Release(); | ||
| } |
There was a problem hiding this comment.
Few issues here:
- this ValueID is not created by the Class. You need to determine if the device in question supports this ValueID (probably based upon the CommandClass Version) and then create the ValueID, and subsequently, in this specific block, only do this update if the CommandClass Version is equal/above the minimum version and you should also check if index 3 is valid in the data recieved.
There was a problem hiding this comment.
I was looking through the ZW docs and it appears DoorCondition is defined as far back as version 1 of the protocol and hasn't changed sense. I'm assuming this negates the need for any version checking? I added a simple validation of index 3.
|
Hey @Fishwaldo, thanks for your comments. I went ahead and made changes addressing them. Let me know if there are any other changes required! |
|
What is the current thought process with this pull request? Does it need more work? |
|
I assume the conflicts that now occured need to be resolved first. I'd be very interested in DoorCondition as well to test on ID Lock. |
|
Would this fix the problem with ID-Lock 150 where I cannot see if door is closed or open? That would be fantastic. Now a I have to use an additional sensor as I am not able use the one in the lock. I have a lock to test on if needed. Your contributions are highly appreciated :-) |
That is my understanding. I also have the ID Lock 150 with an additional sensor to solve this. |
|
When will this be added? =) |
|
Please merge this! Would be a great addition! |
AGREE!! |
|
@Fishwaldo what is needed to make this happen? Do we need testing? |
|
I have this to, |
Implements Door Condition per 1.6 specs under COMMAND_CLASS_DOOR_LOCK
Additionally includes updated xml files for Door Condition and includes August DoorSense™ support