-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid Debian changelogs #5
base: main
Are you sure you want to change the base?
Conversation
I have tested building both Debian packages and RPMs; this change fixes the generation of Debian changelogs that was previously broken without seemingly having any adverse effect on RPM packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
@@ -7,6 +7,7 @@ This changelog adheres to [Keep a CHANGELOG](https://keepachangelog.com). | |||
## [Unreleased] | |||
- Bump minimum ruby requirement to 2.7 | |||
- Fix preserve param default behaving like `always` but should be `on-failure` | |||
- Fix invalid Debian changelogs (#4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for maintainers: do we want to maintain this ChangeLog by hand or rely on tools that use the merged PR to generate a human readable changelog with useful links to the PRs? I really like the automated approach 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to automated
Fixes #4