Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid Debian changelogs #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bootc
Copy link

@bootc bootc commented Feb 8, 2025

Fixes #4

@bootc
Copy link
Author

bootc commented Feb 8, 2025

I have tested building both Debian packages and RPMs; this change fixes the generation of Debian changelogs that was previously broken without seemingly having any adverse effect on RPM packages.

Copy link

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@@ -7,6 +7,7 @@ This changelog adheres to [Keep a CHANGELOG](https://keepachangelog.com).
## [Unreleased]
- Bump minimum ruby requirement to 2.7
- Fix preserve param default behaving like `always` but should be `on-failure`
- Fix invalid Debian changelogs (#4)
Copy link

@smortex smortex Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for maintainers: do we want to maintain this ChangeLog by hand or rely on tools that use the merged PR to generate a human readable changelog with useful links to the PRs? I really like the automated approach 😁

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to automated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Debian changelog files are invalid
3 participants