All-in-one minimal multi-stage Dockerfiles, and GitHub action to buil… #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d release images Trigger on Docker changes, too Fix bug in cache-to declaration when in PR Search the PATH for the ORE executable when running Examples Typo Add basic usage documentation for the container images Use ENTRYPOINT and update docs to match Try to nail down the intra-build cache Use GHA cache anyway, should catch PR rebuilds better Attempt to isolate the various flavour builds from each other within the GHA cache Cache from -latest as well Use dynamic flavour Trigger on workflow changes Attempt to convert "config" to flavour params remove some redundant comments and rearrange for readability Include tests in the Dockerfiles in a skippable way Perform tests inside docker build Clarity changes Make test results register correctly in PRs etc. Fix bad cache spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
centos-stream9,debian11andfedora40which compile & test (with Examples), and package minimal container images for executing ore-engine within a Container, thus avoiding the need for users to install dependencies, compile, etc. manually.centos-stream9anddebian11all automatically, creating release-quality minimal container images in theghcr.iocontainer image repository associated with OpenSourceRisk (see https://github.com/nickcmaynard/ore-engine/pkgs/container/ore-engine)ore, allowing execution of an Example within the container.Limitations:
debian11is notdebian12due to the Python-basedExamples/test suite's requirement for the "nose" library. "nose" needs Python 3.9 and debian12 doesn't have that. This area needs some work from a Python-capable person - "nose" appears to be beset with maintenance and IP concerns.