Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coaster trains with dive loop sprites #372

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

X123M3-256
Copy link
Contributor

This PR updates the OpenRCT2 official coaster train types with the additional sprites required for the new elements added in OpenRCT2/OpenRCT2#23569. It should only be merged after that PR, because otherwise the new sprite groups will not be read properly and the objects will glitch.

I have included sprites for the hybrid train even though my other PR does not add track sprites for that ride type, because I expect I will make sprites for the hybrid at some point and I might as well update the vehicle sprites now. They are also useful if you want to hack the train onto a track type that does get the new elements.

@Gymnasiast
Copy link
Member

@SpartanFrederic104 @ZeeMaji could you test these?

@ZeeMaji
Copy link
Contributor

ZeeMaji commented Jan 10, 2025

Sure thing!

@SpartanFrederic104
Copy link
Contributor

Fred's Workbench 2025-01-11 13-06-41
Fred's Workbench 2025-01-11 12-43-32
Fred's Workbench 2025-01-11 13-05-49
Just ran a quick test, the new sprites look fantastic. I'm also digging the updated LSM train thumbnail, it looks more alive than the previous one.

Copy link
Contributor

@ZeeMaji ZeeMaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working as expected, old parks work fine and the new sprites look excellent. The updated LSM thumbnail is also nice.

Copy link
Contributor

@SpartanFrederic104 SpartanFrederic104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seconding what ZeeMaji said. The new sprites and updated LSM train thumbnail look fantastic, and old saves work nicely with the new sprites.

@Gymnasiast Gymnasiast merged commit aff009f into OpenRCT2:master Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants