-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial versions of peep animation objects #357
Conversation
c05ddc0
to
9effa1d
Compare
7e1a34d
to
f102ede
Compare
I noticed that the RCT1 source games were missing from the objects when objects shared between both RCT1 & RCT2 define RCT2 as the primary source game with whatever RCT1 pack they originated in as a second source game. From some research i did these should be the RCT1 source games for all of the peep animation objects. RCT1: RCT1AA: RCT1LL: Anything not listed here is RCT2 only (eg: pirate costume). |
Good idea. I'll amend my script and redump. |
They're in the wrong order as the first entry is for the primary source game that's displayed in text on the object selection window, it should be like this:
|
@ZeeMaji Thanks, I had no idea. I've changed the order to what you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven’t extensively checked the objects, but since this already got reviewed by Maji, I think we can proceed.
One request: we generally have the en-GB
string on top in the translations. Could you change that order? If not, no big deal.
This is a supporting PR to OpenRCT2/OpenRCT2#23328. The objects proposed in this PR were dumped using a Python script.
To do:
entertainerCostumes
array from scenery groupseatFood
animationI'd prefer this PR to be squash merged into one commit.