Fixes Mage_Eav_Model_Attribute_Data_Date and Mage_Core_Controller_Varien_Action date validations and empty value handling

[massa-man]

Description (*)

Fix to allow clearing the customer DOB in the admin. This PR also fixes some similar issues with other admin controller date management such as Product controller, which does not use a form, but use the _filterDate() and _filterDateTime() helpers in Mage_Core_Controller_Varien_Action, aligning that code with the fixes I did in PR 3752 to the from filters.

Related Pull Requests

• see Fixed Varien_Data_Form_Filter_Date::inputFilter() and Varien_Data_Form_Filter_Datetime::inputFilter() dealing with empty values #3752

Fixed Issues (if relevant)

• fixes Unable to clear/remove customer DOB via admin console #4604

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[sreichel]

Bug confirmed,

Just did a quick ckeck. To solve the issue it only requieres changes to app/code/core/Mage/Eav/Model/Attribute/Data/Date.php.

Why change app/code/core/Mage/Core/Controller/Varien/Action.php?

[massa-man]

Bug confirmed,

Just did a quick ckeck. To solve the issue it only requieres changes to app/code/core/Mage/Eav/Model/Attribute/Data/Date.php.

Why change app/code/core/Mage/Core/Controller/Varien/Action.php?

Yes, the specific issue of customer DOB only requires update to app/code/core/Mage/Eav/Model/Attribute/Data/Date.php. The other changes to the Action controller are two fold:

1. To align the use of Date and DateTime filters for input data to using the same filters for all input (the current Varien Action Date and DateTime filters duplicate the code in Varien_Data_Form_Filter_Date and Varien_Data_Form_Filter_DateTime, which were patched and updated in PR: Fixed Varien_Data_Form_Filter_Date::inputFilter() and Varien_Data_Form_Filter_Datetime::inputFilter() dealing with empty values #3752. This is more of a code improvement/cleanup to consolidate the use of the same filters across the application.

2. The EAV form is only used for the customer entity, all other EAV entities in the admin console (i.e. Catalog Product, etc) seem to use the varien Action _filterDates and _filterDateTime methods to process the attributes input data.

[kiatng]

Validation on required-entry doesn't work. Steps to reproduce:

1. UPDATE `eav_attribute` SET `is_required` = '1' WHERE `eav_attribute`.`attribute_code` = 'dob'
2. Clear DOB in backend, and in developer console, remove required-entry in the class attribute.
3. Save. Expected error message is not thrown.

[kiatng]

I committed a fix for the required-entry validation and push it here: riseart/openmage@bugfix/fix-date-filters-in-varien-action-controller...OpenMage:magento-lts:bugfix/fix-date-filters-in-varien-action-controller I am not sure how to incorporate that into this PR. Any idea?

[massa-man]

I committed a fix for the required-entry validation and push it here: riseart/openmage@bugfix/fix-date-filters-in-varien-action-controller...OpenMage:magento-lts:bugfix/fix-date-filters-in-varien-action-controller I am not sure how to incorporate that into this PR. Any idea?

I can merge this change into my branch so it is all part of this PR. Besides that, are you guys happy to approve and merge this fix?

[massa-man]

Hi all, can we get a second approver on this one so we can merge it? Thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud