build(src,test,lib): properly build project/ignore build products #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekNonGeneric
added
dependencies
Signed-off-by: Restyled Commits <[email protected]>
Signed-off-by: Restyled Commits <[email protected]>
Signed-off-by: Restyled Commits <[email protected]>
Signed-off-by: Restyled Commits <[email protected]>
DerekNonGeneric
commented
Oct 22, 2022
DerekNonGeneric
commented
Oct 22, 2022
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
DerekNonGeneric
force-pushed
the
fix/rm-build-products
branch
from
87d0561 to
927c7b5
Compare
|
The rest of CI's complaints are mostly nits, but worth correcting. Handling that in this PR would be somewhat off-topic, though… I will land this as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed all build products and git-ignored their output directories, partially solving for #73 (roughly half). I have also removed
node-fetchas a dependency and replaced it w/ Undici, contributing to solving #112. The CI doesn't seem to be set up to build and test this project currently, but that should be relatively simple and might be next.I have ensured that it builds locally, though.