Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement configure_acceptance_filters for socketcan #340

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Implement configure_acceptance_filters for socketcan #340

merged 3 commits into from
Jun 13, 2024

Conversation

tomasjakubik
Copy link
Contributor

I know PyCyphal is not intended for embedded, but here's filtering anyway. Please review.

@tomasjakubik tomasjakubik marked this pull request as draft June 11, 2024 12:13
@coveralls
Copy link

Coverage Status

coverage: 94.703% (-0.03%) from 94.728%
when pulling 452e67c on tomasjakubik:filters
into 40e1482 on OpenCyphal:master.

pavel-kirienko
pavel-kirienko requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@pavel-kirienko pavel-kirienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is very good.

Please bump the minor version number and drop a line to CHANGELOG.rst

Thanks!

pycyphal/transport/can/media/socketcan/_socketcan.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 94.708% (-0.02%) from 94.728%
when pulling b461811 on tomasjakubik:filters
into 40e1482 on OpenCyphal:master.

@tomasjakubik tomasjakubik marked this pull request as ready for review June 13, 2024 04:27
@coveralls
Copy link

Coverage Status

coverage: 94.665% (-0.06%) from 94.728%
when pulling 660f625 on tomasjakubik:filters
into 40e1482 on OpenCyphal:master.

@pavel-kirienko pavel-kirienko merged commit 4df7d14 into OpenCyphal:master Jun 13, 2024
11 checks passed
@tomasjakubik tomasjakubik deleted the filters branch June 13, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-kirienko pavel-kirienko pavel-kirienko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomasjakubik @coveralls @pavel-kirienko