-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP-IDF Component Continuous Integration #229
ESP-IDF Component Continuous Integration #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I have created the token and added it to the repository secrets.
CMakeLists.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to hide CMakeLists.txt
, Kconfig
, and idf_component.yml
into a subdirectory, or at least the first two? I don't want to pollute the project root with third-party items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be doable via repository_info
Co-authored-by: Pavel Kirienko <[email protected]>
As you suggested, to avoid polluting the root of the repository with ESP-related files, I tried using So I decided it would be cleanest to just have the continuous integration script copy all the required files into a temporary component directory before publishing. I tested the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please address the last two nits and we'll merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the script go into /esp_metadata
?
esp_metadata/Kconfig
Outdated
increase the cost of RX/TX transfer processing by ~half. | ||
|
||
|
||
endmenu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline at the end
Thank you Pavel! |
This pull request is meant to resolve #227 by adding continuous integration for publishing Libcanard to the ESP Component Registry.
Files added:
idf_component.yml
. This file contains required ESP component metadata.Kconfig
. ESP components use this file as a standard way for controlling build options. I've added options for enabling/disabling assertions and the CRC table.CMakeLists.txt
. This file is required to register the component with the ESP build system..github/workflows/esp_publish.yml
. This workflow uploads the component to the ESP-IDF registry whenever a new GitHub release is published..github/workflows/esp_dry_run.yml
. This workflow does a dry-run of uploading to the ESP-IDF registry, without publishing anything. It can only be manually triggered. I've tested this in my repository, and it seems to work.The GitHub workflows require
IDF_COMPONENT_API_TOKEN
with an ESP registry token to be added to the repository secrets.