Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Empty SHA256/SHA1 field when modifying File Observable (#8973) #8991

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ValentinBouzinFiligran
Copy link
Member

Proposed changes

  • empty hash value won't be displayed on details thanks to a filter

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Nov 13, 2024
@ValentinBouzinFiligran
Copy link
Member Author

I used a filter to not apply any new logic/complexity on SCO mutation or hash processing on the front end.

@ValentinBouzinFiligran ValentinBouzinFiligran linked an issue Nov 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (864bcea) to head (975ee63).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8991      +/-   ##
==========================================
- Coverage   66.29%   66.29%   -0.01%     
==========================================
  Files         597      597              
  Lines       61089    61098       +9     
  Branches     6287     6292       +5     
==========================================
+ Hits        40501    40502       +1     
- Misses      20588    20596       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gwendoline-FAVRE-FELIX
Copy link
Member

Functionally it works, but it still creates empty values in the back. Is this a problem or not?
query stixFile

@ValentinBouzinFiligran ValentinBouzinFiligran merged commit 96bbd5a into master Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty SHA256/SHA1 field when modifying File Observable
2 participants