Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix content export pdf (#8976) #8979

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

marieflorescontact
Copy link
Member

Proposed changes

  • Add check on currentFileId

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 13, 2024
@marieflorescontact marieflorescontact marked this pull request as ready for review November 13, 2024 07:45
@marieflorescontact marieflorescontact requested review from Kedae and removed request for ValentinBouzinFiligran November 13, 2024 07:46
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (864bcea) to head (a7f2fe7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8979      +/-   ##
==========================================
- Coverage   66.29%   66.29%   -0.01%     
==========================================
  Files         597      597              
  Lines       61089    61089              
  Branches     6287     6288       +1     
==========================================
- Hits        40501    40499       -2     
- Misses      20588    20590       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marieflorescontact marieflorescontact merged commit c2ec1fd into master Nov 13, 2024
6 checks passed
@marieflorescontact marieflorescontact deleted the issue/8976 branch November 13, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants