[backend/frontend] Danger zone: Remove FF (#8284)

[marieflorescontact]

Proposed changes

• Removes Feature flag
• documentation PR: [docs] Add protect sensitive configuration documentation (#216) docs#217
• Fixes 2 css issues in RuleList

Related issues

• Protect sensitive features and configurations from modifications #8284

Checklist

• I consider the submitted work as finished
• I tested the code for its functionality
• I wrote test cases for the relevant uses case (coverage and e2e)
• I added/update the relevant documentation (either on github or on notion)
• Where necessary I refactored code to improve the overall quality

Further comments

[codecov]

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.47%. Comparing base (99deaea) to head (ac16009).
Report is 4 commits behind head on release/6.4.0.

Files with missing lines	Patch %	Lines
...pencti-graphql/src/database/data-initialization.js	0.00%	7 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           release/6.4.0    #8905      +/-   ##
=================================================
+ Coverage          64.33%   65.47%   +1.14%     
=================================================
  Files                608      609       +1     
  Lines              58054    58563     +509     
  Branches            6409     7528    +1119     
=================================================
+ Hits               37348    38346     +998     
+ Misses             20706    20217     -489     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[labo-flg]

why this change ?
I would naively think that isAllowed is always true if isSensitive is false (a non-sensitive zone is always granted).

[marieflorescontact]

because the edit button was disabled for non sensitive Group/Role if user was not allowed (not allowed to modified sensitive Group/Role )

[Archidoit]

The Danger Zone button doesn't seem well aligned with the text (it is a bit lower)

button design

[marieflorescontact]

The Danger Zone button doesn't seem well aligned with the text (it is a bit lower)

well in fact this is an illusion:

[Archidoit]

The Danger Zone button doesn't seem well aligned with the text (it is a bit lower)

well in fact this is an illusion:

yes the text in the button is aligned with the text, but the button itself is not aligned... Only design question I don't know if we let that :)

[marieflorescontact]

yes the text in the button is aligned with the text, but the button itself is not aligned... Only design question I don't know if we let that :)

I don't see what is not aligned, could you explain? 💐