Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Merge tabs in simulation form (#1515) #1827

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

johanah29
Copy link
Member

No description provided.

@johanah29
Copy link
Member Author

#1515

@johanah29 johanah29 changed the title [backend|fronted]Merge tabs in simulation form [backend|fronted]Merge tabs in simulation form (#1515) Nov 7, 2024
@guillaumejparis guillaumejparis changed the title [backend|fronted]Merge tabs in simulation form (#1515) [backend/frontend] Merge tabs in simulation form (#1515) Nov 8, 2024
@johanah29 johanah29 marked this pull request as ready for review November 8, 2024 13:42
@johanah29 johanah29 force-pushed the issue/1515 branch 3 times, most recently from 7c1225a to 2339602 Compare November 13, 2024 08:25
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.47%. Comparing base (5609c26) to head (3a1cb1a).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...a/io/openbas/rest/exercise/form/ExerciseInput.java 0.00% 5 Missing ⚠️
...enbas/rest/settings/response/PlatformSettings.java 0.00% 2 Missing ⚠️
...va/io/openbas/service/PlatformSettingsService.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1827      +/-   ##
============================================
+ Coverage     32.37%   32.47%   +0.10%     
- Complexity     1623     1626       +3     
============================================
  Files           561      560       -1     
  Lines         16861    17057     +196     
  Branches        984     1030      +46     
============================================
+ Hits           5459     5540      +81     
- Misses        11160    11279     +119     
+ Partials        242      238       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Nov 13, 2024
@savacano28 savacano28 self-requested a review November 14, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of a simulation - update button should take infos from both tabs overview and mail config
2 participants