[backend/frontend] enforce null consistency with executor and command (#1621)

[antoinemzs]

Proposed changes

• Enforce having a value for both the Cleanup Executor and the Cleanup Command in Payload definition

Related issues

• Closes Payload - Enforce required cleanup command AND executor when choosing one of the two #1621
• Must be merged at the same time: null cleanup executor if command is absent (OpenBAS-Platform/openbas/issues/1621) collectors#49

Checklist

• I consider the submitted work as finished
• I tested the code for its functionality
• I wrote test cases for the relevant uses case
• I added/update the relevant documentation (either on github or on notion)
• Where necessary I refactored code to improve the overall quality

Further comments

On the payload definition panel, it is now not possible to only define the cleanup executor or the cleanup command. Both must be defined at the same time or none of them (i.e. blank fields).

The backend part was done with a "pure" null philosophy, unfortunately the frontend is not yet able to handle null values in react field components: the frontend special cases empty string for fields to submit null instead.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.31%. Comparing base (77b583d) to head (b1d9b67).
Report is 15 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1825      +/-   ##
============================================
+ Coverage     32.08%   32.31%   +0.22%     
+ Complexity     1609     1605       -4     
============================================
  Files           561      562       +1     
  Lines         16850    17049     +199     
  Branches        974     1019      +45     
============================================
+ Hits           5406     5509     +103     
- Misses        11200    11291      +91     
- Partials        244      249       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[antoinemzs]

Deepl translation

[antoinemzs]

Issue found: the new constraint prevents importing the atomic red team database

[antoinemzs]

Issue found: the new constraint prevents importing the atomic red team database

fixed