Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] clean up temporary apt list files in Dockerfiles #1696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PeterDaveHello
Copy link

Proposed changes

  • clean up temporary apt list files in Dockerfiles

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.52%. Comparing base (55d481f) to head (68175d6).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1696   +/-   ##
=========================================
  Coverage     33.52%   33.52%           
  Complexity     1608     1608           
=========================================
  Files           557      557           
  Lines         14477    14477           
  Branches        871      871           
=========================================
  Hits           4854     4854           
  Misses         9398     9398           
  Partials        225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion added the community use to identify PR from community label Oct 20, 2024
@Dimfacion
Copy link
Member

Hi @PeterDaveHello !
Thank you for the pull request! 🎉 We're excited to see your contribution to the project. We'll review it and get back to you soon with any feedback. If you have any questions in the meantime, feel free to ask!
Openbas Team - Filigran

@Dimfacion
Copy link
Member

Hi again !
Could you please sign your commits ?
Thanks :)

@PeterDaveHello
Copy link
Author

Should be done now, thanks.

@guillaumejparis guillaumejparis linked an issue Oct 22, 2024 that may be closed by this pull request
@guillaumejparis
Copy link
Member

Hello @PeterDaveHello unfortunately your commit is still not signed, not sure why as I see the signed off message on your commit but no "verified" tag, maybe see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@PeterDaveHello
Copy link
Author

Hi @guillaume, I’ve added a Signed-off-by, but I haven’t set up a GPG key due to convenience. Given that this is a small change and the commit is still traceable, is it possible to move forward without the verified tag for this PR? Thanks!

@guillaumejparis
Copy link
Member

Yes I understand but even maintainers cannot merge on the repository without signed commit if you want I can close this PR in favor of this one with your commit cherry pick and signed by me : #1736

@PeterDaveHello
Copy link
Author

It seems the rules are quite strict, but I'll try to handle this issue.

@guillaumejparis
Copy link
Member

@PeterDaveHello Hello, did you have some time to try ?

@PeterDaveHello
Copy link
Author

Let me try it at the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean up temporary apt list files in Dockerfiles
3 participants