-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker] clean up temporary apt list files in Dockerfiles #1696
base: master
Are you sure you want to change the base?
[docker] clean up temporary apt list files in Dockerfiles #1696
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1696 +/- ##
=========================================
Coverage 33.52% 33.52%
Complexity 1608 1608
=========================================
Files 557 557
Lines 14477 14477
Branches 871 871
=========================================
Hits 4854 4854
Misses 9398 9398
Partials 225 225 ☔ View full report in Codecov by Sentry. |
Hi @PeterDaveHello ! |
Hi again ! |
Signed-off-by: Peter Dave Hello <[email protected]>
e26604c
to
68175d6
Compare
Should be done now, thanks. |
Hello @PeterDaveHello unfortunately your commit is still not signed, not sure why as I see the signed off message on your commit but no "verified" tag, maybe see https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification |
Hi @guillaume, I’ve added a Signed-off-by, but I haven’t set up a GPG key due to convenience. Given that this is a small change and the commit is still traceable, is it possible to move forward without the verified tag for this PR? Thanks! |
Yes I understand but even maintainers cannot merge on the repository without signed commit if you want I can close this PR in favor of this one with your commit cherry pick and signed by me : #1736 |
It seems the rules are quite strict, but I'll try to handle this issue. |
@PeterDaveHello Hello, did you have some time to try ? |
Let me try it at the weekend! |
Proposed changes
Checklist