Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update of a simulation - update button should take infos from both tabs overview and mail config #1515

Open
EllynBsc opened this issue Sep 23, 2024 · 2 comments · May be fixed by #1827
Open

Update of a simulation - update button should take infos from both tabs overview and mail config #1515

EllynBsc opened this issue Sep 23, 2024 · 2 comments · May be fixed by #1827
Assignees
@johanah29
Labels
bug use for describing something not working as expected UI improvement
Milestone
Bugs backlog

Comments

@EllynBsc
Copy link
Member

EllynBsc commented Sep 23, 2024 •
edited
Loading

Description

At the moment, it is possible to update the information , one tab at a time - either overview or mail configuration.
We have to click on the update button for each tab if we want the info to be updated.

We should be able to update both info from both tabs in one go clicking on the update button.

Usecase: As a user, i can modify the subtitle input from the overview tab as well as the message header from the simulation mail config in one go by clicking on the update button

Image
@EllynBsc EllynBsc added the bug use for describing something not working as expected label Sep 23, 2024
@EllynBsc EllynBsc added this to the Bugs backlog milestone Sep 23, 2024
@johanah29 johanah29 self-assigned this Nov 5, 2024
@EllynBsc
Copy link
Member Author

EllynBsc commented Nov 6, 2024

Hi @johanah29 👋

Decision take today along with @jborozco : merge the 2 tabs (overview and mail configuration) in one drawer.

@EllynBsc EllynBsc mentioned this issue Nov 6, 2024
Open
@EllynBsc
Copy link
Member Author

EllynBsc commented Nov 7, 2024

Here is the design expected @johanah29 (cc @jborozco)

Image

@johanah29 johanah29 linked a pull request Nov 7, 2024 that will close this issue
[backend/frontend] Merge tabs in simulation form (#1515) #1827
Open
@johanah29 johanah29 linked a pull request Nov 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanah29 johanah29

Labels
bug use for describing something not working as expected UI improvement
Projects
None yet
Milestone
Bugs backlog
Development

Successfully merging a pull request may close this issue.

[backend/frontend] Merge tabs in simulation form (#1515) OpenBAS-Platform/openbas
3 participants
@EllynBsc @johanah29 @RomuDeuxfois