Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate poetry to uv #27

Merged
merged 1 commit into from
Mar 29, 2025
Merged

Migrate poetry to uv #27

merged 1 commit into from
Mar 29, 2025

Conversation

eggplants
Copy link
Member

@eggplants eggplants commented Mar 29, 2025

I have migrated Poetry to uv and introduced Dev Container.

@eggplants eggplants force-pushed the uv branch 4 times, most recently from a4fe800 to 49a6899 Compare March 29, 2025 09:05
Copy link

github-actions bot commented Mar 29, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py351071%13, 33, 37–38, 44, 61–64, 68
TOTAL351071% 

Tests Skipped Failures Errors Time
3 0 💤 0 ❌ 0 🔥 5.660s ⏱️

@eggplants eggplants marked this pull request as ready for review March 29, 2025 09:31
@eggplants eggplants requested a review from Copilot March 29, 2025 09:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request migrates the project from Poetry to uv as the build and publish tool and introduces a Dev Container for development.

  • Replaces Poetry configuration with uv/hatchling in pyproject.toml
  • Updates publish.py to invoke uv commands instead of Poetry’s
  • Modifies GitHub workflows and pre-commit configuration to reflect the toolchain change

Reviewed Changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_cli.py Reformats the assertion for better multi-line readability
pyproject.toml Updates the build system and dependency groups to use hatchling and uv
publish.py Switches build/publish commands from Poetry to uv and adjusts formatting
openapi_generator_cli/init.py Adjusts formatting without functional changes
DEVELOPMENT.md Updates setup instructions to reference the Dev Container
.pre-commit-config.yaml Removes Poetry hooks, retains relevant linting hooks
.github/workflows/test.yaml Replaces Poetry setup with uv setup and commands
.github/workflows/publish.yaml Updates publish commands to use uv and new environment variables
.github/dependabot.yml Changes package-ecosystem from pip to uv
Files not reviewed (2)
  • .devcontainer/devcontainer.json: Language not supported
  • .devcontainer/postCreateCommand.sh: Language not supported
Comments suppressed due to low confidence (2)

publish.py:54

  • The explicit close() call is redundant when using a context manager. Please remove it to simplify the code.
openapi_generator_jar.close()

.github/dependabot.yml:3

  • Verify that 'uv' is a supported package ecosystem for Dependabot updates, as this change may affect dependency monitoring.
+- package-ecosystem: uv

@eggplants eggplants requested a review from wing328 March 29, 2025 09:48
@wing328
Copy link
Member

wing328 commented Mar 29, 2025

nice. let's give it a try

@wing328 wing328 merged commit 5e48c47 into master Mar 29, 2025
7 checks passed
@wing328 wing328 deleted the uv branch March 29, 2025 11:39
@eggplants
Copy link
Member Author

Before: 2m13s → After: 46s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants