ExplorerPatcher compatibility #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amrsatrio
reviewed
Jan 19, 2025
| @@ -2956,6 +2969,12 @@ static void InitStartMenuDLL( void ) | |||
| if (GetSettingBool(L"CustomTaskbar")) | |||
| { | |||
| auto module=GetModuleHandle(L"taskbar.dll"); | |||
| if (!module) | |||
| { | |||
| module = GetModuleHandle(L"ep_taskbar.5.dll"); | |||
There was a problem hiding this comment.
Perhaps I should come a up with a way so that any program can read which ep_taskbar is active... hardcoding the module name is not a good idea.
There are currently 6 variants of the taskbar, of which variants 0 (10 VB), 2 (11 NI), and 5 (11 GE) are under active use. Hardcoding this to 5 would make it only target the taskbar if it's running under 11 GE/24H2.
There was a problem hiding this comment.
Thanks.
I have added check also for version 2 as it seems 2 an 5 are the only officially supported by ExporerPatcher.
I guess that should be enough.
I have also added some more safety checks to ExtTextOutW hook.
ge0rdi
force-pushed
the
explorer-patcher-compatibility
branch
from
ea9851f to
39dc75a
Compare
ge0rdi
force-pushed
the
explorer-patcher-compatibility
branch
from
39dc75a to
146c27e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.