This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Added a new Command to lift the elevator using PID with an analogSensor. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaarYogev
suggested changes
Feb 25, 2018
| /** | ||
| * | ||
| */ | ||
| public class LiftUsingPID extends Command { |
There was a problem hiding this comment.
Change to LiftByPotentiometer.
Potentiometer is obvious because we're basing the position on the sensor, not the algorithm.
About by vs with vs using, I think by is the most correct, because with/using is more physical. AccordingTo is totally fine, yet a bit longer than by
There was a problem hiding this comment.
Also change the by thing in other PID commands
|
|
||
| elevatorPitchMotor = new WPI_TalonSRX(8); | ||
|
|
||
| collectorLineTracker = new LineTracker(2, 4); | ||
| elevatorAnalogSensor = new AnalogInput(0); |
| @@ -20,6 +23,8 @@ | |||
| */ | |||
| public class Elevator extends Subsystem { | |||
| private final SpeedControllerGroup elevatorWheels = Robot.m_robotMap.elevatorWheels; | |||
| private final AnalogInput analogSensor = Robot.m_robotMap.elevatorAnalogSensor; | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.