refactor(fx-core): scaffold question and generator refactor #13106
+3,501
−2,517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jayzhang
commented
Jan 24, 2025
•
jayzhang
commented
- Clean unused template name and template "copilot-gpt-from-scratch-plugin".
- Use mapping between question tree node and template name.
- Use mapping between generator and template name.
…e/refactor-question
…e/refactor-question
… huajie/refactor-question
anchenyi
requested changes
Feb 6, 2025
yuqizhou77
reviewed
Feb 6, 2025
tecton
reviewed
Feb 6, 2025
packages/fx-core/src/question/scaffold/vsc/CapabilityOptions.ts
Outdated
Show resolved
Hide resolved
yuqizhou77
reviewed
Feb 6, 2025
* refactor: cleanup code * refactor: cleanup code * test: ut
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yuqizhou77
reviewed
Feb 6, 2025
| static apiKey(): OptionItem { | ||
| return { | ||
| id: "api-key", | ||
| label: "API Key (Bearer Token Auth)", |
There was a problem hiding this comment.
The label here seems same with line 563. @huimiu Can you help confirm whether the label is same for both api-ley and bearer-token?
yuqizhou77
reviewed
Feb 6, 2025
SLdragon
reviewed
Feb 7, 2025
tecton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.