Python Conversion Bot Formatting Cards #1570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 39 out of 53 changed files in this pull request and generated 6 comments.
Files not reviewed (14)
- samples/bot-formatting-cards/python/.env: Language not supported
- samples/bot-formatting-cards/python/.gitignore: Language not supported
- samples/bot-formatting-cards/python/.vscode/extensions.json: Language not supported
- samples/bot-formatting-cards/python/.vscode/launch.json: Language not supported
- samples/bot-formatting-cards/python/.vscode/settings.json: Language not supported
- samples/bot-formatting-cards/python/.vscode/tasks.json: Language not supported
- samples/bot-formatting-cards/python/appManifest/manifest.json: Language not supported
- samples/bot-formatting-cards/python/assets/sample.json: Language not supported
- samples/bot-formatting-cards/python/env/.env.local: Language not supported
- samples/bot-formatting-cards/python/infra/azure.bicep: Language not supported
- samples/bot-formatting-cards/python/infra/azure.parameters.json: Language not supported
- samples/bot-formatting-cards/python/requirements.txt: Language not supported
- samples/bot-formatting-cards/python/bots/init.py: Evaluated as low risk
- samples/bot-formatting-cards/python/bots/botFormattingCards.py: Evaluated as low risk
Comments suppressed due to low confidence (2)
samples/bot-formatting-cards/python/README.md:138
- The method name 'adaptivePeoplePersonaCardIcon' should be 'adaptivePeoplePersonaCardSetIcon'.
- Select method `def adaptivePeoplePersonaCardIcon` at line number `1082`
samples/bot-formatting-cards/python/app.py:37
- [nitpick] The error message could be more descriptive. Consider specifying the type of error that occurred.
await context.send_activity("The bot encountered an error or bug.")
Comment on lines
+36
to
+37
| subscriptionId: ${{AZURE_SUBSCRIPTION_ID}} # The AZURE_SUBSCRIPTION_ID is a built-in environment variable. TeamsFx will ask you select one subscription if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select subscription if it's empty in this case. | ||
| resourceGroupName: ${{AZURE_RESOURCE_GROUP_NAME}} # The AZURE_RESOURCE_GROUP_NAME is a built-in environment variable. TeamsFx will ask you to select or create one resource group if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select or create resource grouop if it's empty in this case. |
There was a problem hiding this comment.
The word 'varialbe' should be corrected to 'variable'.
Suggested change
| subscriptionId: ${{AZURE_SUBSCRIPTION_ID}} # The AZURE_SUBSCRIPTION_ID is a built-in environment variable. TeamsFx will ask you select one subscription if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select subscription if it's empty in this case. | |
| resourceGroupName: ${{AZURE_RESOURCE_GROUP_NAME}} # The AZURE_RESOURCE_GROUP_NAME is a built-in environment variable. TeamsFx will ask you to select or create one resource group if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select or create resource grouop if it's empty in this case. | |
| subscriptionId: ${{AZURE_SUBSCRIPTION_ID}} # The AZURE_SUBSCRIPTION_ID is a built-in environment variable. TeamsFx will ask you select one subscription if its value is empty. You're free to reference other environment variable here, but TeamsFx will not ask you to select subscription if it's empty in this case. | |
| resourceGroupName: ${{AZURE_RESOURCE_GROUP_NAME}} # The AZURE_RESOURCE_GROUP_NAME is a built-in environment variable. TeamsFx will ask you to select or create one resource group if its value is empty. You're free to reference other environment variable here, but TeamsFx will not ask you to select or create resource grouop if it's empty in this case. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Comment on lines
+36
to
+37
| subscriptionId: ${{AZURE_SUBSCRIPTION_ID}} # The AZURE_SUBSCRIPTION_ID is a built-in environment variable. TeamsFx will ask you select one subscription if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select subscription if it's empty in this case. | ||
| resourceGroupName: ${{AZURE_RESOURCE_GROUP_NAME}} # The AZURE_RESOURCE_GROUP_NAME is a built-in environment variable. TeamsFx will ask you to select or create one resource group if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select or create resource grouop if it's empty in this case. |
There was a problem hiding this comment.
The word 'varialbe' should be corrected to 'variable'.
Suggested change
| subscriptionId: ${{AZURE_SUBSCRIPTION_ID}} # The AZURE_SUBSCRIPTION_ID is a built-in environment variable. TeamsFx will ask you select one subscription if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select subscription if it's empty in this case. | |
| resourceGroupName: ${{AZURE_RESOURCE_GROUP_NAME}} # The AZURE_RESOURCE_GROUP_NAME is a built-in environment variable. TeamsFx will ask you to select or create one resource group if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select or create resource grouop if it's empty in this case. | |
| subscriptionId: ${{AZURE_SUBSCRIPTION_ID}} # The AZURE_SUBSCRIPTION_ID is a built-in environment variable. TeamsFx will ask you select one subscription if its value is empty. You're free to reference other environment variable here, but TeamsFx will not ask you to select subscription if it's empty in this case. | |
| resourceGroupName: ${{AZURE_RESOURCE_GROUP_NAME}} # The AZURE_RESOURCE_GROUP_NAME is a built-in environment variable. TeamsFx will ask you to select or create one resource group if its value is empty. You're free to reference other environment variable here, but TeamsFx will not ask you to select or create resource grouop if it's empty in this case. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| - uses: arm/deploy # Deploy given ARM templates parallelly. | ||
| with: | ||
| subscriptionId: ${{AZURE_SUBSCRIPTION_ID}} # The AZURE_SUBSCRIPTION_ID is a built-in environment variable. TeamsFx will ask you select one subscription if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select subscription if it's empty in this case. | ||
| resourceGroupName: ${{AZURE_RESOURCE_GROUP_NAME}} # The AZURE_RESOURCE_GROUP_NAME is a built-in environment variable. TeamsFx will ask you to select or create one resource group if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select or create resource grouop if it's empty in this case. |
There was a problem hiding this comment.
The word 'grouop' should be corrected to 'group'.
Suggested change
| resourceGroupName: ${{AZURE_RESOURCE_GROUP_NAME}} # The AZURE_RESOURCE_GROUP_NAME is a built-in environment variable. TeamsFx will ask you to select or create one resource group if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select or create resource grouop if it's empty in this case. | |
| resourceGroupName: ${{AZURE_RESOURCE_GROUP_NAME}} # The AZURE_RESOURCE_GROUP_NAME is a built-in environment variable. TeamsFx will ask you to select or create one resource group if its value is empty. You're free to reference other environment varialbe here, but TeamsFx will not ask you to select or create resource group if it's empty in this case. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Comment on lines
+282
to
+285
| **Guage Chart :** | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
The word 'Guage' is misspelled. It should be 'Gauge'.
Suggested change
| **Guage Chart :** | |
|  | |
| **Gauge Chart :** | |
|  |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| # If the channel is the Emulator, and authentication is not in use, the AppId will be null. | ||
| # We generate a random AppId for this case only. This is not required for production, since | ||
| # the AppId will have a value. | ||
| APP_ID = SETTINGS.app_id if SETTINGS.app_id else uuid.uuid4() |
There was a problem hiding this comment.
Generating a random UUID for APP_ID if SETTINGS.app_id is None could lead to inconsistencies. Handle this case more explicitly.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
|
||
| # Catch-all for errors. | ||
| async def on_error(context: TurnContext, error: Exception): | ||
| # This check writes out errors to console log .vs. app insights. |
There was a problem hiding this comment.
The comment contains a typo: '.vs.' should be 'vs.'
Suggested change
| # This check writes out errors to console log .vs. app insights. | |
| # This check writes out errors to console log vs. app insights. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.