Add Python bot-conversation sample deployment code with Managed Identity #1566
+214
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukun-dong
reviewed
Feb 14, 2025
| properties: { | ||
| channelName: 'MsTeamsChannel' | ||
| serverFarmId: serverfarm.id |
There was a problem hiding this comment.
Need to add the identity to this app service. Please refer to: https://github.com/OfficeDev/teams-toolkit/blob/62c234bd5d47073cce5970dc862df7a922ac6e02/templates/ts/default-bot/infra/azure.bicep#L70
| @@ -12,4 +12,4 @@ class DefaultConfig: | |||
|
|
|||
| PORT = 3978 | |||
| APP_ID = os.environ.get("MicrosoftAppId", "<<MICROSOFT-APP-ID>>") | |||
| APP_PASSWORD = os.environ.get("MicrosoftAppPassword", "<<MICROSOFT-APP-PASSWORD>>") | |||
| APP_PASSWORD = os.environ.get("MicrosoftAppPassword", "<<MICROSOFT-APP-PASSWORD>>") | |||
There was a problem hiding this comment.
I don't know how botframework python sdk consumes these config but seems BOT_TENANTID and BOT_TYPE is missing here, because js sdk would require these config to make the bot work . This is how js sdk works and I'm not sure it can be used as a reference: https://github.com/OfficeDev/teams-toolkit/blob/0c572e750d8c932b4c82f774a88c3e025d00eb93/templates/ts/default-bot/index.ts#L19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.