Hex encode bidder signatures in S3 published CSVs #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the signature field, which is just raw bytes, was being written directly into the bid history CSVs which are published to S3 by the auctioneer. The uploaded files are for consumption by external parties and not used by the auctioneer after they have been uploaded so no changes are needed to read the files. This change is being made pre-mainnet so we don't need to worry about fixing existing files.
Tristan-Wilson
requested review from
ganeshvanahalli,
joshuacolvin0 and
tsahee
diegoximenes
approved these changes
Feb 14, 2025
tsahee
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the signature field, which is just raw bytes, was being written directly into the bid history CSVs which are published to S3 by the auctioneer.
The uploaded files are for consumption by external parties and not used by the auctioneer after they have been uploaded so no changes are needed to read the files.
This change is being made pre-mainnet so we don't need to worry about fixing existing files.