Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_logs call in small chunks #2951

Merged
merged 9 commits into from
Feb 14, 2025
Merged

Make get_logs call in small chunks #2951

merged 9 commits into from
Feb 14, 2025

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Feb 12, 2025 •
edited
Loading

Pulls in OffchainLabs/bold#729 and OffchainLabs/bold#730

Backport in #2956

closes NIT-3122

@amsanghi amsanghi mentioned this pull request Feb 12, 2025
Merged
@amsanghi amsanghi marked this pull request as ready for review February 12, 2025 17:12
@tsahee tsahee mentioned this pull request Feb 12, 2025
Closed
tsahee
tsahee previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee
Copy link
Collaborator

tsahee commented Feb 13, 2025

#2952 should fix submodule pin check

@amsanghi
Copy link
Contributor Author

@tsahee I have made some more changes mostly added OffchainLabs/bold#730

PTAL, Thanks

@amsanghi amsanghi requested a review from tsahee February 13, 2025 08:27
@amsanghi amsanghi mentioned this pull request Feb 13, 2025
Merged
@amsanghi amsanghi changed the title Make get_logs call in small chunks [NIT-3122] Make get_logs call in small chunks Feb 13, 2025
tsahee
tsahee previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amsanghi amsanghi mentioned this pull request Feb 13, 2025
Merged
@amsanghi amsanghi changed the title [NIT-3122] Make get_logs call in small chunks Make get_logs call in small chunks Feb 13, 2025
@amsanghi amsanghi requested a review from tsahee February 13, 2025 21:12
tsahee
tsahee previously approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amsanghi amsanghi requested a review from tsahee February 14, 2025 04:24
tsahee
tsahee approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee merged commit 7db2456 into master Feb 14, 2025
15 checks passed
@tsahee tsahee deleted the fix_block_master branch February 14, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee approved these changes

@rauljordan rauljordan Awaiting requested review from rauljordan

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

Assignees
No one assigned
Labels
design-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amsanghi @tsahee