[NIT-3084] Check if the JSON-RPC error code is 3 for confirming execution reverted #2924
Conversation
| } | ||
| var rpcError rpc.Error | ||
| ok := errors.As(err, &rpcError) | ||
| if ok && rpcError.ErrorCode() == 3 { |
There was a problem hiding this comment.
I know that this was the task, and remember Lee finding that error code, but so far I found no confirmation that error code 3 does mean "execution reverted".
I think remove this part or find other confirmation for it.
I do like the creation of IsExecutionReverted error function, and would be happy to merge it. Not critical.
There was a problem hiding this comment.
Good catch, so i looked around and it looks like the code is 6 based on https://github.com/OffchainLabs/go-ethereum/blob/master/core/vm/errors.go#L131, let me know if I should change it to 6 or it still makes sense to just just remove the code part.
There was a problem hiding this comment.
Actually nvm , here's the part where code 3 comes from - https://github.com/OffchainLabs/go-ethereum/blob/master/internal/ethapi/errors.go#L37
| } | ||
| var rpcError rpc.Error | ||
| ok := errors.As(err, &rpcError) | ||
| if ok && rpcError.ErrorCode() == 3 { |
Fixes: NIT-3084