ExecutionClient returns PromiseInterface #2856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
diegoximenes
requested review from
ganeshvanahalli,
Tristan-Wilson and
amsanghi
tsahee
previously requested changes
Dec 27, 2024
diegoximenes
force-pushed
the
promise_exec_client
branch
2 times, most recently
from
7f61e06 to
f5034ab
Compare
tsahee
added
the
after-next-version
eljobe
previously approved these changes
Jan 13, 2025
eljobe
dismissed
tsahee’s stale review
I believe all of the changes you requested have been addressed.
tsahee
removed
the
after-next-version
diegoximenes
force-pushed
the
promise_exec_client
branch
from
251166c to
27ad8a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2566
As a preparation for running Consensus and Execution in different processes, in which they communicate through the network, this PR updates ExecutionClient interface functions to return promises.
Later, clients implementing EecutionClient will handle the network communication with Consensus side.
Instead of going over all functions from the different types of execution clients (ExecutionSequencer, ExecutionRecorder, etc), this PR only updates ExecutionClient.
Most alternative execution clients, besides the one that we already have based on geth, will only implement ExecutionClient instead of all execution clients.
So it seems reasonable to scope down and only introduce changes related to ExecutionClient for now.
This PR also introduces TestExecutionClientOnly, that guarantees that using a execution node that only implements functions related to ExecutionClient is enough to handle some scenarios.