Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-2537 #409

Merged
merged 6 commits into from
Feb 20, 2025
Merged

EIP-2537 #409

merged 6 commits into from
Feb 20, 2025

Conversation

diegoximenes
Copy link
Contributor

@diegoximenes diegoximenes commented Feb 13, 2025

Resolves NIT-3102

Cherry picks commits related to to EIP-2537.

Pulled by OffchainLabs/nitro#2955

Copy link

cla-bot bot commented Feb 13, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@diegoximenes diegoximenes marked this pull request as ready for review February 14, 2025 12:58
eljobe
eljobe previously approved these changes Feb 20, 2025
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe
Copy link
Member

eljobe commented Feb 20, 2025

This looks good, but needs some conflicts resolved before we can merge it.

jwasinger and others added 6 commits February 20, 2025 10:21
This change adds more comprehensive benchmarks with a wider-variety of input sizes for g1 and g2 multi exponentiation.
This PR updates the fuzzing verbosity a bit, in case of mismatches
The [kilic](https://github.com/kilic/bls12-381) bls12381 implementation
has been archived. It shouldn't be necessary to include it as a fuzzing
target any longer.

This also adds fuzzers for G1/G2 mul that use inputs that are guaranteed
to be valid. Previously, we just did random input fuzzing for these
precompiles.
Reference:

- Remove MUL precompiles: ethereum/EIPs#8945
- Pricing change for pairing operation:
ethereum/EIPs#9098
- Pricing change for add, mapping and mul operations:
ethereum/EIPs#9097
- Pricing change for MSM operations:
ethereum/EIPs#9116

---------

Co-authored-by: Marius van der Wijden <[email protected]>
Fixes a typo in the error message within the `fuzzCrossG2Add`
function. The panic message incorrectly references "G1 point addition
mismatch" when it should be "G2 point addition mismatch," as the
function deals with G2 points.

This doesn't affect functionality but could cause confusion during
debugging. I've updated the message to reflect the correct curve.
Copy link

cla-bot bot commented Feb 20, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@diegoximenes diegoximenes requested a review from eljobe February 20, 2025 13:42
@diegoximenes
Copy link
Contributor Author

This looks good, but needs some conflicts resolved before we can merge it.

Conflicts resolved.

Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe eljobe merged commit ea3be60 into master Feb 20, 2025
6 of 7 checks passed
@eljobe eljobe deleted the eip2537 branch February 20, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants