Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Sonic chain in SumrBalances data structure and retrieval #877

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Add support for Sonic chain in SumrBalances data structure and retrieval #877

merged 1 commit into from
Mar 18, 2025

Conversation

marcinciarka
Copy link
Member

@marcinciarka marcinciarka commented Mar 18, 2025 •
edited by coderabbitai bot
Loading

Introduce the Sonic chain to the SumrBalances data structure, enabling retrieval of balances for this chain alongside existing ones.

Summary by CodeRabbit

  • New Features
    • Introduced support for a new "sonic" chain in the balance tracking feature. Users will now see a default balance value for sonic displayed within their asset overview. This update ensures that cross-chain data, including sonic, is consistently reflected across all relevant balance views, providing a more comprehensive and transparent experience.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2025 •
edited
Loading

Walkthrough

A new chain, "sonic," is now added to the balance logic. The SumrBalancesData interface includes a new sonic property and the getSumrBalances function's chain configuration incorporates sonic. The result object is updated in both its main structure and the nested raw object with a default value "0" for sonic.

Changes

File Change Summary
apps/earn-protocol/.../index.ts Added sonic: string to SumrBalancesData, updated chain config (SDKChainId.SONIC), set default sonic balance to "0"

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    Client->>Server: Request balances
    Server->>Server: Process chains (incl. sonic)
    Server-->>Client: Return balances with sonic = "0"
Loading

Poem

Sonic beats in code's delight,
A fresh chain springs to light.
Balances set with zero might,
A simple change taking flight.
Cheers to progress, shining bright!

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/earn-protocol/app/server-handlers/sumr-balances/index.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: ESLint configuration in apps/earn-protocol/.eslintrc.cjs » @summerfi/eslint-config/next.cjs » eslint-config-turbo is invalid:

  • Unexpected top-level property "default".

Referenced from: /packages/eslint-config/next.cjs
at ConfigValidator.validateConfigSchema (/node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2177:19)
at ConfigArrayFactory._normalizeConfigData (/node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3019:19)
at ConfigArrayFactory._loadConfigData (/node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2984:21)
at ConfigArrayFactory._loadExtendedShareableConfig (/node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3285:21)
at ConfigArrayFactory._loadExtends (/node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3156:25)
at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)
at _normalizeObjectConfigDataBody.next ()
at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20)
at _normalizeObjectConfigData.next ()
at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/.pnpm/@eslint[email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3095:25)

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Mar 18, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de756ac and 49293d8.

📒 Files selected for processing (1)
  • apps/earn-protocol/app/server-handlers/sumr-balances/index.ts (4 hunks)
🔇 Additional comments (3)
apps/earn-protocol/app/server-handlers/sumr-balances/index.ts (3)

16-16: Interface updated correctly

Sonic property added consistently to both main interface and raw object.

Also applies to: 23-23

134-134: Result object properly initialized

Default values consistently set to '0'.

Also applies to: 141-141

6-6:

❓ Verification inconclusive

Ensure sonic is available in viem/chains package

Verify this import works in all environments.

🏁 Script executed:

#!/bin/bash
# Check if sonic is properly exported from viem/chains
grep -r "export.*sonic" node_modules/viem/

Length of output: 96

Manual Check Required: Verify sonic Export

  • Automated lookup failed (no node_modules folder).
  • Please manually confirm that the sonic export exists in viem/chains for all environments.

@halaprix halaprix merged commit ca22b55 into dev Mar 18, 2025
2 checks passed
@halaprix halaprix deleted the marcinciarka/build-fix branch March 18, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@halaprix halaprix halaprix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcinciarka @halaprix