Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grass.temporal: fix regression in printing metadata #4328

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

petrasovaa
Copy link
Contributor

Fixes #4182 (t.info fails for single registered raster). I tried to work with the current design, although it might have been just easier to revert 7df1a7e, the method inheritance doesn't work very well there.

Besides the reported error, STDSMetadataBase.print_info() was also failing. I tested it with the currently deactivated doctests (there are issue running the doctests unrelated to this).

@petrasovaa petrasovaa added bug Something isn't working backport to 8.4 PR needs to be backported to release branch 8.4 labels Sep 16, 2024
@petrasovaa petrasovaa added this to the 8.4.1 milestone Sep 16, 2024
@github-actions github-actions bot added Python Related code is in Python libraries labels Sep 16, 2024
ninsbl
ninsbl previously approved these changes Sep 19, 2024
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general.

The one comment is probably a leftover and can be removed?

You may consider using just one print statement and multile f-strings in the print function. That would be minimally faster and less code, but that is not essential, I guess...

python/grass/temporal/metadata.py Outdated Show resolved Hide resolved
@petrasovaa
Copy link
Contributor Author

Looks good in general.

The one comment is probably a leftover and can be removed?

You may consider using just one print statement and multile f-strings in the print function. That would be minimally faster and less code, but that is not essential, I guess...

Right, but probably out of scope of this PR, there are many places in there that would have to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 8.4 PR needs to be backported to release branch 8.4 bug Something isn't working libraries Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] t.info fails for single registered raster
2 participants