[WIP] feat: Start using group filtering to define measurements table layout #4501
+152
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viewers
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
feat/measurements-service-filtering
|
| Run status |
|
| Run duration | 02m 17s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
11
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
20
|
Passing
|
13
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
measurement-tracking/OHIFMeasurementPanel.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Measurement Panel > checks if Measurements right panel can be hidden/displayed |
Test Replay
Screenshots
Video
|
|
volume/MPR.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF MPR > should not go MPR for non reconstructible displaySets |
Test Replay
Screenshots
Video
|
|
measurement-tracking/OHIFCornerstoneToolbar.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Cornerstone Toolbar > checks if all primary buttons are being displayed |
Test Replay
Screenshots
Video
|
|
measurement-tracking/OHIFCornerstoneHotkeys.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Cornerstone Hotkeys > checks if hotkeys "R" and "L" can rotate the image |
Test Replay
Screenshots
Video
|
|
customization/HangingProtocol.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF HP > Should display 3 up |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The measurements service already has a few groups of measurement types, it would be nice to have more groups of types and allow them to be listed in various ways in the measurements panel.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment